Problem with onlistitemclick() when using multiple listviews

zumpar · by **zumpar** » Fri Oct 30, 2009 5:21 pm

Hi,

there seem to be a lot of ListView questions on the forum but i didn't really find a similar one to mine. It might be a noobish question but please bear with me

any help is appreciated!

Ive got a ListActivity with 3 lists in the layout of the app. When i wanted to populate the first ListView, ive had problems doing it, as i constantly got the error "your content must have a listview whose id attribute is 'list' ", so i did what everyone advised to do, and changed the id to: android:id="@android:id/list", and along with this code:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
ArrayAdapter<String> dAdapter = new ArrayAdapter<String>(this,R.layout.row, this.myList);
 
this.setListAdapter(dAdapter);
 
Parsed in 0.030 seconds,  using GeSHi 1.0.8.4

it worked.. even though i have tried many times to not do it this way, but never succeeded.
The two other ListViews are populated in the normal fashion:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
ListView myView = (ListView)findviewbyid...... 
 
myView.setAdapter(...)
 
Parsed in 0.030 seconds,  using GeSHi 1.0.8.4

The thing is, i can't get the onListItemClick(ListView l, ...) to work on the other two lists. I tried using an if-statement inside the onlistitemclick listener, which looked something like this:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
if (l == (ListView)findViewById(R.id.secondView)) { then do something else}  or
 
if (l.equals((ListView)findViewById(R.id.thirdView))){ do something else} 
 
Parsed in 0.033 seconds,  using GeSHi 1.0.8.4

but i had no luck with that. Those conditions were never true, and the program never entered the if statement.. so my question is am i doing something wrong ?(im assuming so) What is the correct way to check which ListView was clicked?

Thanks!

wiederke · by **wiederke** » Fri Oct 30, 2009 8:24 pm

Hi,

the ListActivity is only useful if you use exactly one ListView in your activity. Then you don't need to implement some boilerplate code to access the list view.

With your 3 ListView you should extend an normal activity and add the ListViews like you did with your second and third ListView. Use the method ListView.setOnItemClickListener on each of your list views to add a OnItemClickListener to each ListView separatly.

Bye

Torsten

zumpar · by **zumpar** » Fri Oct 30, 2009 11:48 pm

Ah, thanks for the quick reply and for shedding some light on this topic, it really helped me out.

I changed it from a ListActivity to just an Activity,

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
@Override
 
protected void onListItemClick(ListView l, View v, int position, long id) {
Parsed in 0.034 seconds,  using GeSHi 1.0.8.4

to

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
public OnItemClickListener theListListener = new OnItemClickListener() {
 
public void onItemClick(android.widget.AdapterView<?> parent, View v, int position, long id) { .. } }; 
Parsed in 0.035 seconds,  using GeSHi 1.0.8.4

and voila, works

Thanks!

Zeba Momin · by **Zeba Momin** » Thu Dec 17, 2009 11:55 am

hi,
I'm using the ListView as :

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

public class baseForm extends ListActivity {
 
        public ListView lvList;
 
        // for list view
 
        private ArrayList<ListItem> m_orders = null;
 
        private OrderAdapter m_adapter;
 
        private Runnable viewOrders;
 
        private OnItemClickListener listClickListener;
 
        public void onCreate(Bundle icicle) {
 
                super.onCreate(icicle);
 
                setContentView(R.layout.base_form);
 
                lvList = getListView();
 
                lvList.setOnItemClickListener(listClickListener);
 
                listClickListener = new OnItemClickListener() {
 
                        public void onItemClick(AdapterView<?> parent, View v,
 
                                        int position, long id) {
 
                                System.out.println("list item clicked at :"+position);
 
                        }
 
                };
 
         }
Parsed in 0.037 seconds,  using GeSHi 1.0.8.4

But the onItemClick() function doesn't get called on an list item click!!

The xml layout is

Syntax: [ Download ] [ Hide ]

Using xml Syntax Highlighting

<ListView android:id="@android:id/list" android:layout_width="fill_parent"
 
                android:layout_height="fill_parent" android:background="@drawable/back_grnd"
 
                android:listSelector="@drawable/list_select_back" android:clickable="true"/>
Parsed in 0.001 seconds,  using GeSHi 1.0.8.4

Can sumone plzzzz help me wid dis... Thank You...

achie1266 · by **achie1266** » Thu Dec 17, 2009 12:48 pm

listClickListener has not been initialized at the time when you set it to the listView. ou are initializing it after you set it to the listview.
Try initializing your onListItemClick first and then set it to the list. or just remove the onItemClickListener and overwrite it as a seperate method if you are still not able to get it.

Zeba Momin · by **Zeba Momin** » Thu Dec 17, 2009 1:43 pm

this is wat i tried now

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

public void onCreate(Bundle icicle) {
 
                super.onCreate(icicle);
 
                setContentView(R.layout.base_form);
 
                lvList = getListView();
 
                listClickListener = new OnItemClickListener() {
 
                        public void onItemClick(AdapterView<?> parent, View v,
 
                                        int position, long id) {
 
                                System.out.println("::::list clicked from listener::::"+position);
 
                        }
 
                };
 
                lvList.setOnItemClickListener(listClickListener);
 
    }
Parsed in 0.036 seconds,  using GeSHi 1.0.8.4

but it still doesnt seem to wrk...!!!!

I also tried

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
public class baseForm extends ListActivity implements OnItemClickListener { 
 
 public ListView lvList;
 
     // for list view
 
     private ArrayList<ListItem> m_orders = null;
 
     private OrderAdapter m_adapter;
 
     private Runnable viewOrders;
 
     private OnItemClickListener listClickListener;
 
     public void onCreate(Bundle icicle) {
 
          super.onCreate(icicle);
 
          setContentView(R.layout.base_form); 
 
}
 
     @Override
 
        public void onItemClick(AdapterView<?> arg0, View arg1, int arg2, long arg3) {
 
                 System.out.println("list item clicked "); 
 
        }
Parsed in 0.037 seconds,  using GeSHi 1.0.8.4

But even dis didnt wrk..!!
Wat am I going wrong???
Plzzz help...

achie1266 · by **achie1266** » Thu Dec 17, 2009 2:15 pm

I could not find where you have set the listadapter[i am guessing you extended either the base adapter or array adapter]
can you post the layout file and your activity class which you are using so that I can test it out.

what do you mean by it doesn't work.. What error does it give? I would guess its going to some nullPointerException but I cant recreate your problem untill i have the layout and your java class.

Zeba Momin · by **Zeba Momin** » Thu Dec 17, 2009 2:19 pm

thank you for replying again
My .java file is:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

import java.util.ArrayList;
 
import android.app.ListActivity;
 
import android.app.ProgressDialog;
 
import android.content.Context;
 
import android.graphics.drawable.Drawable;
 
import android.os.Bundle;
 
import android.util.Log;
 
import android.view.LayoutInflater;
 
import android.view.View;
 
import android.view.ViewGroup;
 
import android.view.View.OnClickListener;
 
import android.widget.AdapterView;
 
import android.widget.ArrayAdapter;
 
import android.widget.ImageButton;
 
import android.widget.ListView;
 
import android.widget.TextView;
 
import android.widget.AdapterView.OnItemClickListener;
 
public class baseForm extends ListActivity implements OnItemClickListener{
 
        private ImageButton backBtn;
 
        private ImageButton logoBtn;
 
        private ImageButton shareBtn;
 
        private ImageButton iconL;
 
        private ImageButton iconR;
 
        private TextView tvTitle;
 
        private TextView tvHeading;
 
        private TextView tvInfoL;
 
        private TextView tvInfoR;
 
        public ListView lvList;
 
        private String sTitle = "";
 
        // for list view
 
        // private ProgressDialog m_ProgressDialog = null;
 
        private ArrayList<ListItem> m_orders = null;
 
        private OrderAdapter m_adapter;
 
        private Runnable viewOrders;
 
        private static EnumScreenType eScreenType;
 
        private static EnumItemType itemType;
 
        private OnItemClickListener listClickListener;
 
        public void onCreate(Bundle icicle) {
 
                super.onCreate(icicle);
 
                setContentView(R.layout.base_form);
 
                lvList = getListView();
 
                listClickListener = new OnItemClickListener() {
 
                        public void onItemClick(AdapterView<?> parent, View v,
 
                                        int position, long id) {
 
                                System.out.println("::::list clicked from listener::::"+position);
 
                        }
 
                };
 
                lvList.setOnItemClickListener(listClickListener);
 
                m_orders = new ArrayList<ListItem>();
 
                this.m_adapter = new OrderAdapter(this, R.layout.listitem, m_orders);
 
                setListAdapter(this.m_adapter);
 
                viewOrders = new Runnable() {
 
                        @Override
 
                        public void run() {
 
                                getOrders();
 
                        }
 
                };
 
                Thread thread = new Thread(null, viewOrders, "MagentoBackground");
 
                thread.start();
 
        }
 
        private Runnable returnRes = new Runnable() {
 
                @Override
 
                public void run() {
 
                        int size=m_orders.size();
 
                        if (m_orders != null && m_orders.size() > 0) {
 
                                m_adapter.notifyDataSetChanged();
 
                                for (int i = 0; i < size; i++)
 
                                        m_adapter.add(m_orders.get(i));
 
                        }
 
                        m_adapter.notifyDataSetChanged();
 
                }
 
        };
 
        private void getOrders() {
 
                try {
 
                        m_orders = new ArrayList<ListItem>();
 
                        ListScreenData oListScreenData = new ListScreenData();
 
                        oListScreenData.fillListItem(m_orders, eScreenType);
 
                        System.out.println("oListScreenData created..//....."
 
                                        + m_orders.size());
 
                } catch (Exception e) {
 
                        Log.e("BACKGROUND_PROC", e.getMessage());
 
                }
 
                runOnUiThread(returnRes);
 
        }
 
        private class OrderAdapter extends ArrayAdapter<ListItem> {
 
                private ArrayList<ListItem> items;
 
                public OrderAdapter(Context context, int textViewResourceId,
 
                                ArrayList<ListItem> items) {
 
                        super(context, textViewResourceId, items);
 
                        this.items = items;
 
                }
 
                @Override
 
                public View getView(int position, View convertView, ViewGroup parent) {
 
                        View v = convertView;
 
                        if (v == null) {
 
                                LayoutInflater vi = (LayoutInflater) getSystemService(Context.LAYOUT_INFLATER_SERVICE);
 
                                v = vi.inflate(R.layout.listitem, null);
 
                        }
 
                        ListItem o = items.get(position); 
 
                        if (o != null) {
 
                                tvHeading = (TextView) v.findViewById(R.id.toptext);
 
                                tvInfoL = (TextView) v.findViewById(R.id.bottomtextleft);
 
                                tvInfoR = (TextView) v.findViewById(R.id.bottomtextright);
 
                                iconL = (ImageButton) v.findViewById(R.id.iconL);
 
                                iconR = (ImageButton) v.findViewById(R.id.iconR);
 
                                System.out.println("in get view...got all stuff.....");
 
                                if (tvHeading != null) {
 
                                        o.getHeading();
 
                                        tvHeading.setText(o.sHeading);
 
                                }
 
                                if (tvInfoL != null) {
 
                                        o.getSubheadingL();
 
                                        if (o.sSubHeadingL == null) {
 
                                                tvInfoL.setVisibility(View.GONE);
 
                                        } else {
 
                                                tvInfoL.setVisibility(View.VISIBLE);
 
                                                tvInfoL.setText(o.sSubHeadingL);
 
                                        }
 
                                }
 
                                if (tvInfoR != null) {
 
                                        o.getSubheadingR();
 
                                        if (o.sSubHeadingR == null) {
 
                                                tvInfoR.setVisibility(View.GONE);
 
                                        } else {
 
                                                tvInfoR.setVisibility(View.VISIBLE);
 
                                                tvInfoR.setText(o.sSubHeadingR);
 
                                        }
 
                                }
 
                                if (iconL != null) {
 
                                        o.getIconLeftImage();
 
                                        if (o.bIconL == true) {
 
                                                if (o.bFolder == true) {
 
                                                        iconL
 
                                                                        .setBackgroundDrawable(Main.objGUIEngine
 
                                                                                        .getIconImage(
 
                                                                                                        EnumItemType.FolderBttnLeft_ItemType,
 
                                                                                                        false, null, null));
 
                                                }
 
                                                iconL.setVisibility(View.VISIBLE);
 
                                        } else {
 
                                                iconL.setVisibility(View.GONE);
 
                                        }
 
                                }
 
                                if (iconR != null) {
 
                                        o.getIconRightImage();
 
                                        if (o.bIconR == true && o.bFolder == true) {
 
                                                iconR.setBackgroundDrawable(Main.objGUIEngine
 
                                                                .getIconImage(
 
                                                                                EnumItemType.FolderBttnRight_ItemType,
 
                                                                                null, null, null));
 
                                                iconR.setVisibility(View.VISIBLE);
 
                                        } else {
 
                                                iconR.setVisibility(View.GONE);
 
                                        }
 
                                }
 
                        }
 
                        return v;
 
                }
 
        }
 
        @Override
 
        public void onItemClick(AdapterView<?> arg0, View arg1, int arg2, long arg3) {
 
                System.out.println("::::list clicked from listener::::");
 
        }
 
}
Parsed in 0.059 seconds,  using GeSHi 1.0.8.4

and layout file is:

Syntax: [ Download ] [ Hide ]

Using xml Syntax Highlighting

 
<?xml version="1.0" encoding="utf-8"?>
 
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
 
        android:orientation="vertical" android:layout_width="fill_parent"
 
        android:layout_height="fill_parent">
 
        <RelativeLayout android:id="@+id/Header"
 
                android:layout_toRightOf="@+id/btnBack" android:layout_height="40dip"
 
                android:background="@drawable/topbar320px2" android:layout_width="fill_parent">
 
                <ImageButton android:id="@+id/Back" android:layout_height="wrap_content"
 
                        android:layout_width="wrap_content" android:layout_marginLeft="0dip"
 
                        android:visibility="invisible" android:background="@drawable/topbar_back_up_320x480"/>
 
                <TextView android:layout_toRightOf="@+id/Back" android:id="@+id/Title"
 
                        android:layout_width="wrap_content" android:layout_height="wrap_content"
 
                        android:layout_marginTop="10dip" android:layout_marginLeft="20dip"
 
                        android:textStyle="bold" android:textColor="#ffffff"
 
                        android:soundEffectsEnabled="false" android:textSize="20dip"
 
                        android:layout_marginBottom="15dip" android:gravity="center_vertical"
 
                        android:layout_marginRight="10dip" />
 
                <ImageButton android:layout_toRightOf="@+id/Title"
 
                        android:id="@+id/Logo" android:layout_height="wrap_content"
 
                        android:layout_width="wrap_content" android:background="@drawable/logo"
 
                        android:layout_marginLeft="25dip" />
 
                <ImageButton android:layout_toRightOf="@+id/Logo"
 
                        android:id="@+id/Share" android:layout_height="wrap_content"
 
                        android:layout_width="wrap_content" android:background="@drawable/topbar_share_up_320x480"
 
                        android:layout_marginLeft="101dip" android:visibility="invisible" />
 
        </RelativeLayout>
 
        <ImageButton android:id="@+id/Dragger"
 
                android:layout_height="wrap_content" android:layout_width="wrap_content"
 
                android:background="@drawable/dragger_open_down" android:clickable="true" />
 
        <ListView android:id="@android:id/list" android:layout_width="fill_parent"
 
                android:layout_height="fill_parent" android:background="@drawable/back_grnd"
 
                android:listSelector="@drawable/list_select_back" android:clickable="true"/>
 
</LinearLayout>
Parsed in 0.008 seconds,  using GeSHi 1.0.8.4

and it doesnt work means... I dont get the sop out on my logcat console when i click on a list item..I donot get ne error of ne sorts...

achie1266 · by **achie1266** » Thu Dec 17, 2009 3:03 pm

the problem is with the java class, I do not see any problems in the listlayout. I did not test it out or examine clearly, I just looked at the id]

can you try making these changres in your java class
remove the

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

lvList = getListView();
 
          listClickListener = new OnItemClickListener() {
 
               public void onItemClick(AdapterView<?> parent, View v,
 
                         int position, long id) {
 
                    System.out.println("::::list clicked from listener::::"+position);
 
               }
 
          };
 
          lvList.setOnItemClickListener(listClickListener); 
Parsed in 0.036 seconds,  using GeSHi 1.0.8.4

and try to implement that logic in your onItemClick method which you are implementing since you need to implement that method from the interface.

2nd option
try to modify your code to even remove that interface and just override the onListItemClick method. I normally use this but its just a matter of preference and what we need.
Here is how you code may look like one you follow the second option

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

package com.achie.test;
 
import java.util.ArrayList;
 
import android.app.ListActivity;
 
import android.app.ProgressDialog;
 
import android.content.Context;
 
import android.graphics.drawable.Drawable;
 
import android.os.Bundle;
 
import android.util.Log;
 
import android.view.LayoutInflater;
 
import android.view.View;
 
import android.view.ViewGroup;
 
import android.view.View.OnClickListener;
 
import android.widget.AdapterView;
 
import android.widget.ArrayAdapter;
 
import android.widget.ImageButton;
 
import android.widget.ListView;
 
import android.widget.TextView;
 
import android.widget.AdapterView.OnItemClickListener;
 
//removed the interface implementation[rename the class to your class]
 
public class Sample1 extends ListActivity{
 
     private ImageButton backBtn;
 
     private ImageButton logoBtn;
 
     private ImageButton shareBtn;
 
     private ImageButton iconL;
 
     private ImageButton iconR;
 
     private TextView tvTitle;
 
     private TextView tvHeading;
 
     private TextView tvInfoL;
 
     private TextView tvInfoR;
 
     public ListView lvList;
 
     private String sTitle = "";
 
     // for list view
 
     // private ProgressDialog m_ProgressDialog = null;
 
     private ArrayList<ListItem> m_orders = null;
 
     private OrderAdapter m_adapter;
 
     private Runnable viewOrders;
 
     private static EnumScreenType eScreenType;
 
     private static EnumItemType itemType;
 
//     private OnItemClickListener listClickListener;
 
     public void onCreate(Bundle icicle) {
 
          super.onCreate(icicle);
 
          setContentView(R.layout.base_form);
 
//          lvList = getListView();
 
//          listClickListener = new OnItemClickListener() {
 
//               public void onItemClick(AdapterView<?> parent, View v,
 
//                         int position, long id) {
 
//                    System.out.println("::::list clicked from listener::::"+position);
 
//
 
//               }
 
//          };
 
//
 
//          lvList.setOnItemClickListener(listClickListener);
 
          m_orders = new ArrayList<ListItem>();
 
          this.m_adapter = new OrderAdapter(this, R.layout.listitem, m_orders);
 
          setListAdapter(this.m_adapter);
 
          viewOrders = new Runnable() {
 
               @Override
 
               public void run() {
 
                    getOrders();
 
               }
 
          };
 
          Thread thread = new Thread(null, viewOrders, "MagentoBackground");
 
          thread.start();
 
     }
 
     //your methods
 
     private class OrderAdapter extends ArrayAdapter<ListItem> {
 
          private ArrayList<ListItem> items;
 
          public OrderAdapter(Context context, int textViewResourceId,
 
                    ArrayList<ListItem> items) {
 
               super(context, textViewResourceId, items);
 
               this.items = items;
 
          }
 
          // your implementation
 
     }
 
     //changed to the method you need to override
 
     protected void onListItemClick(ListView l, View v, int position, long id) {
 
          // TODO Auto-generated method stub
 
     }
 
}
 
Parsed in 0.048 seconds,  using GeSHi 1.0.8.4

I posted comments in the code where you might need changes.
Hope it helps you

Zeba Momin · by **Zeba Momin** » Fri Dec 18, 2009 10:40 am

Hey...
I tried the solution u mentioned above..but yet i did not get the onClick event!!!!
I den tried with an sample application, which has the ListActivity as its launcher activity in the manifest file of the application and it worked.... the callback was called!!!
In my application... I hav another activity 'GUIEngine' as my launcher activity in which at some point of time..the ListActivity 'baseForm' in started as:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

Intent mainIntent = new Intent(GUIEngine.this, baseForm.class);
 
                GUIEngine.this.startActivity(mainIntent);
Parsed in 0.035 seconds,  using GeSHi 1.0.8.4

So, is it dat..the GUIEngine is getting the onclick event??? :?:

Plzz help me out wid dis..I'm stuck on dis since d last 2 days..

achie1266 · by **achie1266** » Fri Dec 18, 2009 11:31 am

what are the changes that you made? came u post that java file.

Did you remove the implements interface on your class and then try setting the onlistItemClick on the listView too?
somethinglike

public class baseForm extends ListActivity[try extending Activity too]

and in ur method

ListView lv = (ListView)findViewById(R.id.your_list);
lv.setOnListItemClick(new .......)

You may even extend just an Activity and customize every thing.
PM me your email if it doesn't work and I can send you a sample application that I did. ( I can't do it right away though as I am off to bed [i live in mountain time]).

There is a post that i posted which has a code with another problem but with a working onItemClickListener. you may check it out from my posts.

good luck.

Zeba Momin · by **Zeba Momin** » Sat Dec 19, 2009 12:02 pm

Hello achie...
I solved the problem atlast!!!!
The callback was not happening as I had a ImageButton in my row layout :!:

Thanks for all your help