Emmanuel7 wrote:Really nice, congratulations !
I think it will interest a lot of people here !
Just two (small) points ( yes, I really did read your code :) ) :
* Why a setOrientation ( VERTICAL ) ? It won't work in horizontal mode ?
* The way you post a empty message to create a timer 'looks' strange. I've always seen a generic handler used, with mHandler.postDelayed(mUpdateTimeTask, mUpdateInterval ); called, with mUpdateTimeTask a runnable with a run() method doing whatever we want. Note that the fact that I always seen this method is far from meaning it is superior :)
* ( Yes, I know I said two points ) : your code is much more lighter than the Home sliding drawer (here ). Are there some features missing in your version ?
Thanks for this nice contribution !
MrSnowflake wrote:Awsome, looks great, I'm probably gonna use it in my new project, I'm currently working on.
What's the licence? GPL/Apache/BSD/pure public domain?
I have one remark: in the exceptions you throw you are talking about id attributes with the name R.id.panelContent. But the actual Id is panelContent, without the R.id. ! Just so your exceptions become more correct :).
Oh rly? . Well then, that's very good then and you may ignore, my ignorance .pskink wrote:for exception: the check was 'stolen' from some google sources (TabHost.java IIRC) and i wanted to be consistent since they also used R.id prefix.
MrSnowflake wrote:Well then, that's very good then and you may ignore, my ignorance :).
I would say not so good, as I didn't know those are the same as Google uses. On the other hand, as I didn't know this, it must mean I never encountered such an Exception, which means my coding skills are through the roof .pskink wrote:MrSnowflake wrote:Well then, that's very good then and you may ignore, my ignorance .
i wouldn't call it 'ignorance', rather good detective's inspection/investigation - good for you!
Emmanuel7 wrote:Wahooo !!
There are four of them on every sides !
Congratulation on continuing to improve your widget !
now even i am impressed since code is yet more simple but got extra flexibility - Interpolators.
i must say Animations and Interpolators really ROCK!
Users browsing this forum: No registered users and 8 guests