Emmanuel7 wrote:Waoo !!
I must admit I don't really see what is missing now in order to make it a real v1.0 version.
see 3 TODOs in Panel.java, last two are minor, but the first one imho should be fixed somehow, but i dont know how...
Emmanuel7 wrote:Waoo !!
Two little points :
* First :
There is a bug ! when you drag the handle to have the panel fully expanded ( and pass the limit ), if you release the click button, the panel will instantly close itself. I changed the line 318 :
Using java Syntax Highlighting
if (calculatedDuration == 0 ) { Parsed in 0.030 seconds, using GeSHi 1.0.8.4
intoUsing java Syntax Highlighting
if (calculatedDuration == 0 && mIsShrinking) { Parsed in 0.030 seconds, using GeSHi 1.0.8.4
And it looks like the problem is fixed !
(it's in the startAnimation runnable )
you were VERY close, but i think we should really avoid animation when calculatedDuration == 0 so:
Using java Syntax Highlighting
- if (calculatedDuration == 0) {
- mState = State.READY;
- if (mIsShrinking) {
- mContent.setVisibility(GONE);
- }
- return;
- }
Parsed in 0.034 seconds, using GeSHi 1.0.8.4
Emmanuel7 wrote:*Second point :
I added another layout for you to test, to show something cool that perhaps you didn't think about :
You can have several panel on the same side !!!
And I think you should still add some functions to open / close the panel, both with and without the animation, from outside code.( but it should be something like 4 lines of code from what I have seen )
Really a nice thread :)
big thanks for new layout! i added it as default
added also isOpen and setOpen methods: setOpen is little longer than 4 lines but still small ;)





