Need to close thread and database?

[cabernet1976]

Do I need to close thread and database in Activity's onDestroy? e.g.

Syntax: [ Download ] [ Hide ]

Syntax: [ Download ] [ Show ]

Using java Syntax Highlighting

1.  
2.         @Override
3.  
4.         public void onDestroy() {
5.  
6.                 myThread.interrupt();
7.  
8.                 myDB.close();
9.  
10.                
11.  
12.                 super.onDestroy();
13.  
14.         }

Parsed in 0.030 seconds, using GeSHi 1.0.8.4

Or could you give me a suggestion about the thread and database?
Thank you.

[cabernet1976]

My program often gets the following log in LogCat:
----
D/dalvikvm(744): Exception java/lang/IllegalStateException from SQLiteCursor.java:384 not caught locally
I/dalvikvm(744): Uncaught exception thrown by finalizer (will be discarded):
I/dalvikvm(744): java/lang/IllegalStateException: Finalizing cursor android.database.sqlite.SQLiteCursor@4004d370 on t_Accounts that has not been deactivated or closed
I/dalvikvm(744): at android.database.sqlite.SQLiteCursor.finalize(SQLiteCursor.java:384)
I/dalvikvm(744): at android.dalvik.NativeStart.run(Native Method)
----

I wonder what happen, but the program runs fine.

[cabernet1976]

Could somebody help me or give me some suggestions
Thank you

[res]

I would close the database in the finally block after you have opened it. Thats how I've seen in tutorials thus far.

Syntax: [ Download ] [ Hide ]

Syntax: [ Download ] [ Show ]

Using java Syntax Highlighting

1. try
2.  
3. {
4.  
5.     open database
6.  
7.     ....
8.  
9.     execute SQL
10.  
11. } catch (Exception e) {}
12.  
13. finally {
14.  
15.    if database != null
16.  
17.       close database
18.  
19. }

Parsed in 0.030 seconds, using GeSHi 1.0.8.4

[cabernet1976]

Hi res,

Thanks for your reply.

I think I should refine my program, the current implement of mine is: open database in activity's onCreate (or class' constructor) and operate database's tables in any place of the class.
I will open database only when I need to operate the tables, and close it at once after completing the operation.

Thank you again.

[res]

As time goes by we will discover the best ways to use database's in Android, for now though its probably easiest to just follow the tutorials from Google.