IconTextMenu Challenge ;-)

sommeralex · by **sommeralex** » Wed Jan 30, 2008 8:03 pm

I am still working on my IconTextMenu, maybe some could help me again.. it doesnt work, but i dont know why, there is no

Log.i("iconTextElement", "clicked");

output in my LogCat Console but also - no error!

main xml:

Syntax: [ Download ] [ Hide ]

Using xml Syntax Highlighting

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:orientation="vertical"
    android:layout_width="fill_parent"
    android:layout_height="fill_parent"
    >
<com.airwriting.android.tests.IconTextMenuView id="@+id/icontextmenu1"
    android:layout_width="fill_parent" 
    android:layout_height="wrap_content" 
    />
</LinearLayout>
 
 
Parsed in 0.002 seconds,  using GeSHi 1.0.8.4

my starter class text

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
package com.airwriting.android.tests;
 
import android.app.Activity;
import android.os.Bundle;
import android.util.Log;
import android.view.View;
import android.view.View.OnClickListener;
 
public class Test extends Activity {
    /** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle icicle) {
        super.onCreate(icicle);
        setContentView(R.layout.main);
       
       IconTextMenuView iconTextMenuView = (IconTextMenuView) findViewById(R.id.icontextmenu1);
       
       iconTextMenuView.setOnClickListener(clickListener);
     
    }
    
        OnClickListener clickListener = new OnClickListener() {
                public void onClick(View v) {
                        Log.i("iconTextElement", "clicked");
                        
                }
                
        };              
}
 
Parsed in 0.033 seconds,  using GeSHi 1.0.8.4

and now the iconTextMenuView

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
package com.airwriting.android.tests;
 
 
import java.util.Map;
 
import android.content.Context;
 
import android.graphics.Typeface;
import android.util.AttributeSet;
import android.util.Log;
import android.view.View;
import android.widget.ImageView;
import android.widget.LinearLayout;
import android.widget.TextView;
 
 
/**
 * adapted from plusminus by sommeralex <img src="http://www.anddev.org/images/smilies/wink.png" alt=";-)" title="Wink" />
 */
public class IconTextMenuView extends LinearLayout implements android.view.View.OnClickListener          {
 
        // ===========================================================
        // Fields
        // ===========================================================
 
        
        ;
        private ImageView menuIcon = null;
        private TextView menuText = null;
 
        // ===========================================================
        // Constructors
        // ===========================================================
 
        public IconTextMenuView(Context context) {
                super(context);
 
        }
 
        public IconTextMenuView(Context context, AttributeSet attrs,
                        Map inflateParams) {
                super(context, attrs, inflateParams);
                
                
                Log.i("Wf", "icon created");
                
                this.setOnClickListener(this);
                
                /* Setup the ImageView that will show weather-icon. */
                this.menuIcon = new ImageView(context);
                this.menuIcon.setImageDrawable(getResources().getDrawable(
                                R.drawable.dunno));
 
                /* Setup the textView that will show the temperature. */
                this.menuText = new TextView(context);
                this.menuText.setText("menuText");
                this.menuText.setTextSize(8);
                this.menuText.setTypeface(Typeface
                                .create("Tahoma", Typeface.BOLD));
 
                /* Add child views to this object. */
                this.addView(this.menuIcon, new LinearLayout.LayoutParams(
                                LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT));
                this.addView(this.menuText, new LinearLayout.LayoutParams(
                                LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT));
        }
 
 
        public void onClick(View arg0) {
                // TODO Auto-generated method stub      
                Log.i("InnerListenerOfofIconTextMenu", "clicked");
                
        }
}
 
Parsed in 0.038 seconds,  using GeSHi 1.0.8.4

nor the InnerListenerOfIconTextMenu "clicked" info comes when i click on it, nor the outer listener i set in the test activity (Log.i("iconTextElement", "clicked"); )

:cry:

Ishtar · by **Ishtar** » Thu Jan 31, 2008 12:32 pm

I think the problem is that your IconTextMenuView extends LinearLayout. Let me try to fix it...

Ishtar

Ishtar · by **Ishtar** » Thu Jan 31, 2008 1:38 pm

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
public class IconTextMenuView extends LinearLayout { 
 
public IconTextMenuView(Context context, AttributeSet attrs, 
 
              Map inflateParams) {
 
   // blablabla
 
         setFocusable(true); //not sure if you need this.. 
 
         requestFocus(); //or this..
 
}
 
    @Override
 
    public boolean onMotionEvent(MotionEvent e)
 
    {
 
        // do we need to check if this event actually happend in our View??
 
        if (e.getAction()==MotionEvent.ACTION_DOWN)
 
        {
 
                performClick();
 
                return true;
 
        }
 
        return super.onMotionEvent(e);
 
    }
 
}
 
Parsed in 0.037 seconds,  using GeSHi 1.0.8.4

This worked for me. Took me a while to figure this one out

If its still not working,, or if you get problems when you put more views in your layout. Please post

Ishtar

sommeralex · by **sommeralex** » Thu Jan 31, 2008 2:08 pm

thx, i did something similiar already, after hours of experimentating
i just overwrote the onMotion (and this works) - but i did not mention to perform an OnClick

- so at least i can see that my approach is good - because its the same as yours ;-)

thank you very much!

Ishtar · by **Ishtar** » Thu Jan 31, 2008 2:21 pm

performClick will call the clicklistener that was set, so that would be the preferred way to do it. Keeps your view to follow the android API :wink:

You're welcome!
Ishtar

sommeralex · by **sommeralex** » Thu Jan 31, 2008 2:33 pm

so, then it seems i still cant or wont follow the android-api. why is there an onClickListener, when i have to call onMotion first?

normally (lets say at J2ME, or simple just swing), if you have a button listener, you also dont have to overwrite an "onMotion" method which fires the onClick Listener then..

and WHERE can i find in the api this information? ("please use onMotion to perform the onClick action, even if you want to use the onClickListener..")

hm..

Ishtar · by **Ishtar** » Thu Jan 31, 2008 2:46 pm

Look, an motionevent just occurs, it gets then send to (all/one??) view. This view can decide what to do with it. A button would call performClick (if its a click-motion-event), but a linearlayout would do nothing. Also if you press the "OK" button on your phone while a button has focus, it will receive an key-event, and will call performClick, again the linearlayout would do nothing with it. There is no way for android to know if it was a "click", the view itself has to decide that. Maybe a bit different from swing (didnt use it that much). I assume swing works in the same way, a button will get (something like) a mousevent, and then fire a clickevent. If your IconTextMenuView would extend button, or any other widget that can be clicked, there would be no problem. But you extended a view that does not know what to do with clicks, so you got to implement it. (don't get me wrong, its a good to extend the linear layout :wink:

)

Ishtar

sommeralex · by **sommeralex** » Thu Jan 31, 2008 3:08 pm

(thx again for you answer..but;)

i know that normally it (the linear layout) would do nothing, for that reason i did:

1. public class IconTextMenuView extends LinearLayout implements android.view.View.OnClickListener
2. this.setOnClickListener(this);
3. and last but not least, i implemented the onClick-method.

Ishtar · by **Ishtar** » Thu Jan 31, 2008 3:32 pm

I see... I don't plan on starting to explain all what has to be done to implement a GUI system thing. Cuz i don't know it all :wink:

With these 3 things. Still something, some class, has to call the clicklistener with onClick. Since only your view knows what the clicklistener is, theres a method in your view, that fires the clicklistener. The performClick() method does just that. I guess you expect the Android API to call performClick() when the user clicked on it. The problem is, android doesn't know its a "click", maybe its a drag, and besides clicks can come in other ways, like press the big-middle button, on a focussed view. Android can't call performClick, cuz it doesn't know if/when it's a click. So android sends the event (the motionevent) to the view, and let it handle it. All clickable widgets will call their performclick, all other views, will ignore it. If you know that event is a click, you have to call performClick.

Might be difference with swing (if it works different as you say) that in android we get more "control" but at the price that we to have to implement more.

That a view gets touched (it is a touchscreen) is not the same as being clicked. most likely it is, but the api can not and should not know that. (Designing apis isn't easy matter...)

One remark:
if you set, onClickListener(this); You better override performClick...

Ishtar

sommeralex · by **sommeralex** » Thu Jan 31, 2008 3:52 pm

so i think i got the idea, the difference to swing is, that listeners dont have to be fired (by performs) explicitly, they are, if implemented, "active". They are: listening.

My "baseListener" now is (and stays) the onMotion Listener. And from it as a base, i forward motion-activities to myListener(s).

thank you again..

Ishtar · by **Ishtar** » Thu Jan 31, 2008 4:05 pm

Well, every api is different. Too bad the androids api is so soo badly documented, insights like this came from trial and error, instead of reading a lot of pages. Be careful though, phones without a touchscreen, won't be able to trigger the motionlistener.... Thats why i still think its better to stick with the onclicklistener, and fire that event "manually".

No problem

Ishtar

sommeralex · by **sommeralex** » Thu Jan 31, 2008 4:40 pm

at least, i understood this:

IconTextMenu Challenge ;-)

IconTextMenu Challenge ;-)

Who is online