Help with messy code?

ramgraph1 · by **ramgraph1** » Fri Jan 25, 2008 12:14 am

I have some pictures that change according to their state. I am using code like this to change them:

Code: Select all: if (pic1 == 1) { pic1.setImageResource(R.drawable.blue); } if (pic1 == 2) { pic1.setImageResource(R.drawable.red); } if (pic1 == 3) { pic1.setImageResource(R.drawable.green); } if (pic2 == 1) { pic2.setImageResource(R.drawable.blue); } etc.

Because I have lots of pictures, the code is really long and wastes time whenever I need to change it. The pictures all need unique names but they all change to the same drawables for each state (any that are state 1 are "blue", etc.).
Is there a way to simplify this code and just say, "For all you pictures, if your state is 1 then setImageResource(R.drawable.blue)"?
Thanks for any help you can give!

Ishtar · by **Ishtar** » Fri Jan 25, 2008 4:16 pm

Hi!

Yes, that would become quite messy :wink:

. You should store your pictures, and their states in an array (or if you delete/remove them often, a suitable List). With an array you can easily do this:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
int numPictures=5;
 
int state_blue=1;  //declaring this numbers makes your code more readable -> no "magic" numbers
 
int state_red=2;
 
int state_green=3; //these ints could best be final and static, declare them so in your class
 
Picture []myPictures=new Picture[numPictures];
 
int []states=new int[numPictures];
 
myPictures[0]=new Picture();
 
states[0]=state_green;
 
//etc
 
for (int i=0;i<numPictures;i++)
 
{
 
 if (myPictures[i]!=null)
 
 {
 
  switch(states[i])
 
  {
 
  case state_blue:
 
  myPictures[i].setImageResource(R.drawable.blue); 
 
  break;
 
  case state_red:
 
  myPictures[i].setImageResource(R.drawable.red);
 
  break;
 
  case state_green:
 
  myPictures[i].setImageResource(R.drawable.green); 
 
  break;
 
  default:
 
  // woops! invalid state
 
  } 
 
 }
 
 else
 
  //woops! no picture
 
}
 
Parsed in 0.033 seconds,  using GeSHi 1.0.8.4

You can't say "for all pictures if your state is.." however, you can loop them all like in this code.
Set the pictures and states and change the "woops" with whatever you want to do there.

Ishtar

ramgraph1 · by **ramgraph1** » Fri Jan 25, 2008 10:45 pm

Thanks, that's what I was looking for. As someone pretty new to programming I have been rather intimidated by arrays. Hopefully this will help me make friends with them!

Ishtar · by **Ishtar** » Fri Jan 25, 2008 10:54 pm

Your welcome!
New to programming and already jumping in an api like android?

I'll just warn you, itll be a bumpy ride :wink:

Don't be afraid to ask your questions.

Happy coding,
Ishtar

Help with messy code?

Help with messy code?

Who is online