ProgressDialog does not work

Pogio · by **Pogio** » Tue Feb 09, 2010 7:59 pm

Does not seem to operate the ProgressDialog should go away after the loaded content, however remains them!

can you help me?

This is the code:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
package Oroscopo.grg;
 
import java.io.IOException;
 
import java.io.InputStream;
 
import java.io.InputStreamReader;
 
import java.net.HttpURLConnection;
 
import java.net.URL;
 
import java.net.URLConnection;
 
import android.app.ProgressDialog; 
 
import android.app.Activity;
 
import android.graphics.Bitmap;
 
import android.graphics.BitmapFactory;
 
import android.os.Bundle;
 
import android.widget.ImageView;
 
import android.widget.TextView;
 
public class arietesett extends Activity {
 
    /** Called when the activity is first created. */
 
        protected ProgressDialog myProgressDialog; 
 
        @Override
 
    public void onCreate(Bundle savedInstanceState) {
 
        super.onCreate(savedInstanceState);
 
        setContentView(R.layout.fuocosett);
 
        /* Show a progress-bar */ 
 
        myProgressDialog = ProgressDialog.show(arietesett.this, 
 
                  "Please wait...", "Doing Extreme Calculations...", true); 
 
        new Thread() { 
 
             public void run() { 
 
    Bitmap bitmap = 
 
        DownloadImage("http://www.moongate.it/oroscopo/arietesett.png");
 
    ImageView img = (ImageView) findViewById(R.id.img);
 
    img.setImageBitmap(bitmap);
 
    Bitmap bitmap1 = 
 
        DownloadImage1("http://www.moongate.it/oroscopo/arietetext.png");
 
    ImageView imgt = (ImageView) findViewById(R.id.imgt);
 
    imgt.setImageBitmap(bitmap1);
 
    /*String str =
 
        DownloadText("http://www.moongate.it/oroscopo/ariete.txt");
 
    TextView txt = (TextView) findViewById(R.id.text);
 
    txt.setText(str); 
 
    */
 
    String str1 =
 
        DownloadText1("http://www.moongate.it/oroscopo/data.txt");
 
    TextView txt1 = (TextView) findViewById(R.id.data);
 
    txt1.setText(str1);
 
} 
 
            };
 
        }
 
    private InputStream OpenHttpConnection(String urlString) 
 
    throws IOException
 
    {
 
        InputStream in = null;
 
        int response = -1;
 
        URL url = new URL(urlString); 
 
        URLConnection conn = url.openConnection();
 
        if (!(conn instanceof HttpURLConnection))                     
 
            throw new IOException("Not an HTTP connection");
 
        try{
 
            HttpURLConnection httpConn = (HttpURLConnection) conn;
 
            httpConn.setAllowUserInteraction(false);
 
            httpConn.setInstanceFollowRedirects(true);
 
            httpConn.setRequestMethod("GET");
 
            httpConn.connect(); 
 
            response = httpConn.getResponseCode();                 
 
            if (response == HttpURLConnection.HTTP_OK) {
 
                in = httpConn.getInputStream();                                 
 
            }                     
 
        }
 
        catch (Exception ex)
 
        {
 
            throw new IOException("Error connecting");            
 
        }
 
        return in;     
 
    }
 
    private Bitmap DownloadImage(String URL)
 
    {        
 
        Bitmap bitmap = null;
 
        InputStream in = null;        
 
        try {
 
            in = OpenHttpConnection(URL);
 
            bitmap = BitmapFactory.decodeStream(in);
 
            in.close();
 
        } catch (IOException e1) {
 
            // TODO Auto-generated catch block
 
            e1.printStackTrace();
 
        }
 
        return bitmap;                
 
    }
 
    private Bitmap DownloadImage1(String URL)
 
    {        
 
        Bitmap bitmap = null;
 
        InputStream in = null;        
 
        try {
 
            in = OpenHttpConnection(URL);
 
            bitmap = BitmapFactory.decodeStream(in);
 
            in.close();
 
        } catch (IOException e1) {
 
            // TODO Auto-generated catch block
 
            e1.printStackTrace();
 
        }
 
        return bitmap;                
 
    }
 
    /*private String DownloadText(String URL)
 
    {
 
        int BUFFER_SIZE = 2000;
 
        InputStream in = null;
 
        try {
 
            in = OpenHttpConnection(URL);
 
        } catch (IOException e1) {
 
            // TODO Auto-generated catch block
 
            e1.printStackTrace();
 
            return "";
 
        }
 
        InputStreamReader isr = new InputStreamReader(in);
 
        int charRead;
 
          String str = "";
 
          char[] inputBuffer = new char[BUFFER_SIZE];          
 
        try {
 
            while ((charRead = isr.read(inputBuffer))>0)
 
            {                    
 
                //---convert the chars to a String---
 
                String readString = 
 
                    String.copyValueOf(inputBuffer, 0, charRead);                    
 
                str += readString;
 
                inputBuffer = new char[BUFFER_SIZE];
 
            }
 
            in.close();
 
        } catch (IOException e) {
 
            // TODO Auto-generated catch block
 
            e.printStackTrace();
 
            return "";
 
        }    
 
        return str; 
 
    } */
 
    private String DownloadText1(String URL)
 
    {
 
        int BUFFER_SIZE = 2000;
 
        InputStream in = null;
 
        try {
 
            in = OpenHttpConnection(URL);
 
        } catch (IOException e1) {
 
            // TODO Auto-generated catch block
 
            e1.printStackTrace();
 
            return "";
 
        }
 
        InputStreamReader isr = new InputStreamReader(in);
 
        int charRead;
 
          String str1 = "";
 
          char[] inputBuffer = new char[BUFFER_SIZE];          
 
        try {
 
            while ((charRead = isr.read(inputBuffer))>0)
 
            {                    
 
                //---convert the chars to a String---
 
                String readString = 
 
                    String.copyValueOf(inputBuffer, 0, charRead);                    
 
                str1 += readString;
 
                inputBuffer = new char[BUFFER_SIZE];
 
            }
 
            in.close();
 
        } catch (IOException e) {
 
            // TODO Auto-generated catch block
 
            e.printStackTrace();
 
            return "";
 
        }    
 
        return str1; 
 
    }
 
}
 
Parsed in 0.051 seconds,  using GeSHi 1.0.8.4

mitutitu · by **mitutitu** » Tue Feb 09, 2010 9:14 pm

Hello Pogio,

At first I should say that your thread is not correct. You created it but not started. And you can't dismiss your progress dialog when you even don't know from where your thread control should be taken by yourself. And to get the control back of this thread you are badly in need of a Handler object. So here your modified code looks like :

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

package Oroscopo.grg; 
 
import java.io.IOException; 
 
import java.io.InputStream; 
 
import java.io.InputStreamReader; 
 
import java.net.HttpURLConnection; 
 
import java.net.URL; 
 
import java.net.URLConnection; 
 
import android.app.ProgressDialog; 
 
import android.app.Activity; 
 
import android.graphics.Bitmap; 
 
import android.graphics.BitmapFactory; 
 
import android.os.Bundle; 
 
import android.widget.ImageView; 
 
import android.widget.TextView; 
 
import android.os.Handler;  //this is import for handler object
 
public class arietesett extends Activity { 
 
    /** Called when the activity is first created. */ 
 
     protected ProgressDialog myProgressDialog;
 
    @Override 
 
    public void onCreate(Bundle savedInstanceState) { 
 
        super.onCreate(savedInstanceState); 
 
        setContentView(R.layout.fuocosett); 
 
        /* Show a progress-bar */ 
 
        myProgressDialog = ProgressDialog.show(arietesett.this, 
 
                  "Please wait...", "Doing Extreme Calculations...", true); 
 
        new Thread() { 
 
             public void run() { 
 
    Bitmap bitmap = 
 
        DownloadImage("http://www.moongate.it/oroscopo/arietesett.png"); 
 
    ImageView img = (ImageView) findViewById(R.id.img); 
 
    img.setImageBitmap(bitmap); 
 
    Bitmap bitmap1 = 
 
        DownloadImage1("http://www.moongate.it/oroscopo/arietetext.png"); 
 
    ImageView imgt = (ImageView) findViewById(R.id.imgt); 
 
    imgt.setImageBitmap(bitmap1); 
 
    /*String str = 
 
        DownloadText("http://www.moongate.it/oroscopo/ariete.txt"); 
 
    TextView txt = (TextView) findViewById(R.id.text); 
 
    txt.setText(str); 
 
    */ 
 
    String str1 = 
 
        DownloadText1("http://www.moongate.it/oroscopo/data.txt"); 
 
    TextView txt1 = (TextView) findViewById(R.id.data); 
 
    txt1.setText(str1); 
 
handler.sendEmptyMessage(0); //Here thread execution is finished and control transferred to the handler object
 
} 
 
            }.start(); // if you write annonymous class for Thread object creation you should start thread like this 
 
        } 
 
 private Handler handler = new Handler() {
 
                @Override
 
                public void handleMessage(Message msg) {
 
                        super.handleMessage(msg);
 
                myProgressDialog.dismiss(); // here your progress dialog is dismissed indicating process is finished
 
              // Here you can write other processing code if you want
 
                    }
 
             };
 
}
 
    private InputStream OpenHttpConnection(String urlString) 
 
    throws IOException 
 
    { 
 
        InputStream in = null; 
 
        int response = -1; 
 
        URL url = new URL(urlString); 
 
        URLConnection conn = url.openConnection(); 
 
        if (!(conn instanceof HttpURLConnection))                     
 
            throw new IOException("Not an HTTP connection"); 
 
        try{ 
 
            HttpURLConnection httpConn = (HttpURLConnection) conn; 
 
            httpConn.setAllowUserInteraction(false); 
 
            httpConn.setInstanceFollowRedirects(true); 
 
            httpConn.setRequestMethod("GET"); 
 
            httpConn.connect(); 
 
            response = httpConn.getResponseCode();                 
 
            if (response == HttpURLConnection.HTTP_OK) { 
 
                in = httpConn.getInputStream();                                 
 
            }                     
 
        } 
 
        catch (Exception ex) 
 
        { 
 
            throw new IOException("Error connecting");             
 
        } 
 
        return in;     
 
    } 
 
    private Bitmap DownloadImage(String URL) 
 
    {         
 
        Bitmap bitmap = null; 
 
        InputStream in = null;         
 
        try { 
 
            in = OpenHttpConnection(URL); 
 
            bitmap = BitmapFactory.decodeStream(in); 
 
            in.close(); 
 
        } catch (IOException e1) { 
 
            // TODO Auto-generated catch block 
 
            e1.printStackTrace(); 
 
        } 
 
        return bitmap;                 
 
    } 
 
    private Bitmap DownloadImage1(String URL) 
 
    {         
 
        Bitmap bitmap = null; 
 
        InputStream in = null;         
 
        try { 
 
            in = OpenHttpConnection(URL); 
 
            bitmap = BitmapFactory.decodeStream(in); 
 
            in.close(); 
 
        } catch (IOException e1) { 
 
            // TODO Auto-generated catch block 
 
            e1.printStackTrace(); 
 
        } 
 
        return bitmap;                 
 
    } 
 
    /*private String DownloadText(String URL) 
 
    { 
 
        int BUFFER_SIZE = 2000; 
 
        InputStream in = null; 
 
        try { 
 
            in = OpenHttpConnection(URL); 
 
        } catch (IOException e1) { 
 
            // TODO Auto-generated catch block 
 
            e1.printStackTrace(); 
 
            return ""; 
 
        } 
 
        InputStreamReader isr = new InputStreamReader(in); 
 
        int charRead; 
 
          String str = ""; 
 
          char[] inputBuffer = new char[BUFFER_SIZE];           
 
        try { 
 
            while ((charRead = isr.read(inputBuffer))>0) 
 
            {                     
 
                //---convert the chars to a String--- 
 
                String readString = 
 
                    String.copyValueOf(inputBuffer, 0, charRead);                     
 
                str += readString; 
 
                inputBuffer = new char[BUFFER_SIZE]; 
 
            } 
 
            in.close(); 
 
        } catch (IOException e) { 
 
            // TODO Auto-generated catch block 
 
            e.printStackTrace(); 
 
            return ""; 
 
        }     
 
        return str; 
 
    } */ 
 
    private String DownloadText1(String URL) 
 
    { 
 
        int BUFFER_SIZE = 2000; 
 
        InputStream in = null; 
 
        try { 
 
            in = OpenHttpConnection(URL); 
 
        } catch (IOException e1) { 
 
            // TODO Auto-generated catch block 
 
            e1.printStackTrace(); 
 
            return ""; 
 
        } 
 
        InputStreamReader isr = new InputStreamReader(in); 
 
        int charRead; 
 
          String str1 = ""; 
 
          char[] inputBuffer = new char[BUFFER_SIZE];           
 
        try { 
 
            while ((charRead = isr.read(inputBuffer))>0) 
 
            {                     
 
                //---convert the chars to a String--- 
 
                String readString = 
 
                    String.copyValueOf(inputBuffer, 0, charRead);                     
 
                str1 += readString; 
 
                inputBuffer = new char[BUFFER_SIZE]; 
 
            } 
 
            in.close(); 
 
        } catch (IOException e) { 
 
            // TODO Auto-generated catch block 
 
            e.printStackTrace(); 
 
            return ""; 
 
        }     
 
        return str1; 
 
    }     
 
}
 
Parsed in 0.053 seconds,  using GeSHi 1.0.8.4

I commented codes those are written by me. You can identify them easily.

Hope this will work for you.

Thanks,
mitu

Pogio · by **Pogio** » Tue Feb 09, 2010 10:19 pm

Thank you very much, I am a beginner, I'm learning.
your code I from an error "Syntax error on token"} ", delete this token"

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
private Handler handler = new Handler() { 
 
          @Override 
 
          public void handleMessage(Message msg) { 
 
               super.handleMessage(msg); 
 
          myProgressDialog.dismiss(); // here your progress dialog is dismissed indicating process is finished 
 
              // Here you can write other processing code if you want 
 
          }                   
 
             };
 
 } //Here I from the error "Syntax error on token"} ", delete this token"
 
Parsed in 0.033 seconds,  using GeSHi 1.0.8.4

mitutitu · by **mitutitu** » Wed Feb 10, 2010 7:03 am

Hi Pogio,

I'm sorry for that. May be when I was typing code this curly brace is missplaced. Delete this "}" (second closing bracket). And it'll work.

Thanks,
mitu

Pogio · by **Pogio** » Wed Feb 10, 2010 8:40 pm

Hello Mitu, again many thanks
I deleted "}", now reports me this error

Why?

Pogio · by **Pogio** » Wed Feb 10, 2010 10:52 pm

follow the directions of eclipse
I have removed

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

@ Override
Parsed in 0.034 seconds,  using GeSHi 1.0.8.4

and I added

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

import android.os.Message;
Parsed in 0.035 seconds,  using GeSHi 1.0.8.4

not gave more error

but launching program from the following error

mitutitu · by **mitutitu** » Thu Feb 11, 2010 5:18 am

Hi Pogio,

It seems this is the problem in your application. You should better look at logCat and you will see a bunch of error messages. From there you can identify what is the actual problem is.

Thanks,
mitu

Pogio · by **Pogio** » Thu Feb 11, 2010 7:21 pm

Sorry, where I see these logcat?

Pogio · by **Pogio** » Thu Feb 11, 2010 8:03 pm

you I enclose the complete project, you can watch it?

Pogio · by **Pogio** » Sun Feb 14, 2010 9:00 pm

Nobody knows help me

mitutitu · by **mitutitu** » Mon Feb 15, 2010 6:29 am

Hello Pogio,

I've solved your problem. The problem was that you hav set your content view in the main thread(Actual activity is the main thread) but used findViewById() from within your new thread which is created in onCreate() method of the activity and hav set values inside your new thread. You can't do this. You can't set textview.setText() or imageview.setBackgroundResource() inside a newly created thread whereas the setContentView() is in main thread. If you do then you will get this error msg:

Code: Select all: 02-15 12:01:45.915: ERROR/AndroidRuntime(966): android.view.ViewRoot$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.

Always follow this convention that where you set your content view you should work with your views in the same thread.

Your code is now working fine. Hopefully you can find where the changes are taken place.

Thanks,
mitu

Pogio · by **Pogio** » Mon Feb 15, 2010 9:00 am

It is fantastic! Thank you very much.
impossible for me to succeed, it was too complex for my knowledge.

ProgressDialog does not work

ProgressDialog does not work

Who is online