Doing HTTP Post with Android

aetmos · by **aetmos** » Fri Jan 18, 2008 12:36 am

Hi All,

I'm trying to use Nanodeath's HTTP_Request class, but I'm getting this error:

PostHandler cannot be resolved to a type

on this line

Code: Select all: request.setHandler(new PostHandler(){

Any ideas why? It's finding HTTP_Request okay.

Thanks,
Tom

Nanodeath · by **Nanodeath** » Fri Jan 18, 2008 12:40 am

Might have to qualify it like "new HTTP_Request.PostHandler" (or add an import at the top).

aetmos · by **aetmos** » Fri Jan 18, 2008 12:40 am

Nevermind, I just needed an HTTP_Request. in front of it, I guess.

aetmos · by **aetmos** » Fri Jan 18, 2008 12:41 am

Nanodeath wrote:Might have to qualify it like "new HTTP_Request.PostHandler" (or add an import at the top).

Thanks

I guess I figured it out a second too late...

aetmos · by **aetmos** » Fri Jan 18, 2008 12:42 am

And it works! Thanks for this great Class!

aetmos · by **aetmos** » Fri Jan 18, 2008 12:45 am

Now does anybody know how to resolve these warnings in HTTP_Request?

Set is a raw type. References to generic type Set<E> should be parameterized

on

Code: Select all: Set keys = variables.keySet();

and

Iterator is a raw type. References to generic type Iterator<E> should be parameterized

on

Code: Select all: for(Iterator i = keys.iterator(); i.hasNext();){

Sorry if this is obvious...Java and Android are pretty new to me

Thanks,
Tom

Nanodeath · by **Nanodeath** » Fri Jan 18, 2008 12:51 am

This is a little off topic, but Java "wants" you to use the Generics version of data structures (and their iterators) whenever possible. Back in Ye Olde Days, data structures only held objects and any objects you put into them had to be cast back into their original types when you pulled them out again. This is annoying and not terribly "safe" (possible ClassCastException). So...you say Set<SomeOtherType> thatThatSet = new Set<SomeOtherType>(); and...that pretty much takes care of all the problems. Hopefully the solution to the iterator question falls out of that somewhere.

plusminus · by **plusminus** » Fri Jan 18, 2008 1:06 am

Hey guys,
To resolve the Warning: "Set is a raw type. References to generic type Set<E> should be parameterized." probably also within the for-loop alter the following:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

                 Set<String> keys = variables.keySet();
                 
                 for(Iterator<String> i = keys.iterator(); i.hasNext();){
                         // ... saves you this cast.
                         String key = (String)i.next();
                         // ...
                 }
Parsed in 0.031 seconds,  using GeSHi 1.0.8.4

This is just done to satisfy the compiler and to get some develop-time type-safety.

Regards,
plusminus

Nanodeath · by **Nanodeath** » Fri Jan 18, 2008 1:53 am

Okay, I've made another version. Main points, it's now ResponseHandler instead of PostHandler (since it can be GET or POST) and I've moved the variable-handling stuff to the go() function so that you can sorta create a template HTTP_Request in your class and then invoke it from different methods in the class with different variables but the same url. Plus I added some more comments and a couple minor tweaks here and there. Oh, and now you can get by without a ResponseHandler at all (caused null pointer exc before). I think I'm done messing with it now...

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

import java.io.ByteArrayInputStream;
 
import java.io.UnsupportedEncodingException;
 
import java.net.URLEncoder;
 
import java.util.HashMap;
 
import java.util.Iterator;
 
import java.util.Map;
 
import java.util.Set;
 
import org.apache.http.util.ByteArrayBuffer;
 
import android.content.Context;
 
import android.net.http.EventHandler;
 
import android.net.http.Headers;
 
import android.net.http.RequestQueue;
 
import android.net.http.SslCertificate;
 
import android.util.Log;
 
/***
 
 * Perform GET or POST requests easily and handle responses, status checks, and errors.
 
 * Encapsulated in a class by Nanodeath
 
 * @author plusminus
 
 * @author nanodeath
 
 *
 
 */
 
public class HTTP_Request {
 
        // Fields
 
        private Context context;
 
        private String url;
 
        private Method method;
 
        /***
 
         *      Possible modes to make requests
 
         */
 
        public enum Method {
 
                POST,
 
                GET
 
        }
 
        // Constructors
 
        public HTTP_Request(Context c, String url, Method method) {
 
                this.context = c;
 
                this.url = url;
 
                this.method = method;   
 
        }
 
        private ResponseHandler handler;
 
        /***
 
         * Optionally, you can process any output the url generates when accessed.  You can do so here.
 
         * @param h The response handler you want this object to use
 
         */
 
        public void setHandler(ResponseHandler h){
 
                handler = h;
 
        }
 
        /***
 
         * Initiates the defined HTTP_Request without any variables
 
         */
 
        public void go(){
 
                go(null);
 
        }
 
        /***
 
         * Initiates the defined HTTP_Request with the given variables as arguments
 
         * @param variables Key,value pairs to be sent to the webservice
 
         */
 
        public void go(Map<String,String> variables){
 
                if(handler == null){
 
                        handler = new ResponseHandler();
 
                }
 
                /* Create a new EventHandler defined above, to handle what gets returned. */
 
                MyEventHandler myEvH = new MyEventHandler(handler);
 
                /* Create a new HTTP-RequestQueue. */
 
                android.net.http.RequestQueue rQueue = new RequestQueue(context);         
 
                /* Create a header-hashmap */
 
                Map<String, String> headers = new HashMap<String, String>();
 
                /* and put the Default-Encoding for html-forms to it. */
 
                headers.put("Content-Type", "application/x-www-form-urlencoded");
 
                /* Prepare the variables we are going to send. */
 
                String variablesURL;
 
                if(variables != null && variables.size() > 0){
 
                        try {
 
                                StringBuilder b = new StringBuilder();
 
                                Set<String> keys = variables.keySet();
 
                                // Iterate over each variable you want and append it to our variablesURL variable 
 
                                for(Iterator<String> i = keys.iterator();;){
 
                                        String key = i.next();
 
                                        b.append(key);
 
                                        b.append("=");
 
                                        b.append(URLEncoder.encode(variables.get(key), "UTF-8"));
 
                                        // Minor speed optimization so that i.hasNext() is only called once (instead of in the for loop).
 
                                        if(i.hasNext()){
 
                                                b.append("&");
 
                                        } else {
 
                                                break;
 
                                        }
 
                                }
 
                                variablesURL = b.toString();
 
                        } catch (UnsupportedEncodingException e) {
 
                                Log.e("HTTP_Request", "Unsupported Encoding Exception");
 
                                return;
 
                        }
 
                } else {
 
                        variablesURL = "";
 
                }
 
                if(method == Method.GET){
 
                        // Perform the request with GET
 
                        if(!variablesURL.equals("")){
 
                                url = url + "?" + variablesURL;
 
                        }
 
                        rQueue.queueRequest(url, "GET", headers, myEvH, null, 0, false);
 
                } else if(method == Method.POST){
 
                        /* And put the encoded bytes into an BAIS,
 
                         * where a function later can read bytes from. */
 
                        byte[] POSTbytes = variablesURL.getBytes();
 
                        ByteArrayInputStream baos = new ByteArrayInputStream(POSTbytes);
 
                        rQueue.queueRequest(url, "POST", headers, myEvH, baos, POSTbytes.length, false);                        
 
                } else {
 
                        // Hopefully this could never actually occur
 
                        return;
 
                }
 
                /* Wait until the request is complete.*/
 
                rQueue.waitUntilComplete();
 
        }
 
        // ===========================================================
 
        // Worker Class
 
        // ===========================================================
 
        private class MyEventHandler implements EventHandler {
 
                private ResponseHandler handler;
 
                /** Will hold the data returned by the URLCall. */
 
                ByteArrayBuffer baf = new ByteArrayBuffer(20);
 
                MyEventHandler(ResponseHandler callback) {
 
                        this.handler = callback;
 
                }
 
                public void data(byte[] bytes, int len) {
 
                        baf.append(bytes, 0, len);
 
                }
 
                public void endData() {
 
                        handler.run(new String(baf.toByteArray()));
 
                }
 
                public void status(int arg0, int arg1, int HTTPstatusCode, String status) {
 
                        // HTTPstatusCode can be 200 for OK, 404 for Not Found, etc.
 
                        // Status can be OK, Not Found, others...                       
 
                        handler.status(status);
 
                }
 
                public void error(int i, String s) {
 
                        handler.error(s);
 
                }
 
                public void handleSslErrorRequest(int arg0, String arg1, SslCertificate arg2) { }
 
                public void headers(Iterator arg0) { }
 
                public void headers(Headers arg0) { }
 
        }
 
        public static class ResponseHandler {
 
                public void run(String response){}
 
                public void status(String status) {}
 
                public void error(String error) {}
 
        }
 
}
Parsed in 0.049 seconds,  using GeSHi 1.0.8.4

aetmos · by **aetmos** » Fri Jan 18, 2008 3:25 am

Excellent. Thanks for the explanations and the new class. Works great.

One thing I thought I'd mention...if you're using your implementation of the class on the first page, you have to change this:

Code: Select all: void run(String response) { Log.d("HTTP_Request", "RESPONSE: " + response); } @Override void error(String error) { Log.e("HTTP_Request", "ERROR: " + error); } @Override void status(String status) { Log.i("HTTP_Request", "STATUS:" + status); }

to this:

Code: Select all: public void run(String response) { Log.d("HTTP_Request", "RESPONSE: " + response); } @Override public void error(String error) { Log.e("HTTP_Request", "ERROR: " + error); } @Override public void status(String status) { Log.i("HTTP_Request", "STATUS:" + status); }

for obvious reasons.

Tom

Androider · by **Androider** » Thu Jan 24, 2008 1:16 pm

Can we cancel the Request once we issued the request.

Tnx.

Nanodeath · by **Nanodeath** » Thu Jan 24, 2008 4:51 pm

Well, it seems to be me like if one wanted to do that, it would happen in the RequestQueue (rQueue), but the only relevant methods it has are queueRequest and waitUntilComplete. I was hoping for a clearQueue, dequeue, pop, etc, but there doesn't seem to be one. So, to the best of my limited knowledge, and strictly speaking, I don't think there's a way to cancel a request in progress.

ramgraph1 · by **ramgraph1** » Tue Feb 12, 2008 12:00 am

Using the original code by plusminus above and changing the php file's URL to my own php file's, the app runs in the emulator but I am only getting this in the warning dialog:

Data loaded:
POSTed data:''

It seems like it is working halfway as it is getting the "POSTed data:" part from the php file but for some reason is not getting the message I was trying to send. Right?
I am getting a warning on this line of code:

Code: Select all: public void headers(Iterator arg0) { }

with Eclipse saying I should "rename in file"...
Any ideas what I am doing wrong? The php file is exactly the same as the one used by plusminus above.
Thanks for any help you can give.

cyberrob · by **cyberrob** » Wed Feb 13, 2008 8:07 am

ramgraph1 wrote:Using the original code by plusminus above and changing the php file's URL to my own php file's, the app runs in the emulator but I am only getting this in the warning dialog:

Data loaded:
POSTed data:''

It seems like it is working halfway as it is getting the "POSTed data:" part from the php file but for some reason is not getting the message I was trying to send. Right?

This is a easy one~So I solve this surprisingly! :oops:

You have to edit your php file.Its just a little bug.
From

Code: Select all: <?php echo "POSTed data: '".$_POST['data']."'"; ?>

To

Code: Select all: <?php echo "POSTed data: '".$_POST['mydata']."'"; ?>

Cos in java we annouce the "mydata", not "data".

I am getting a warning on this line of code:
Code: Select all
public void headers(Iterator arg0) { }

with Eclipse saying I should "rename in file"...
Any ideas what I am doing wrong? The php file is exactly the same as the one used by plusminus above.
Thanks for any help you can give.

I got the same warning, but it's ok. you dont have to change anything to run this example successfully.

BR,
Robert

plusminus · by **plusminus** » Wed Feb 13, 2008 9:22 am

Hey guys,

...which will simply echo the 'mydata' variable posted to it:

Syntax: [ Download ] [ Hide ]

Using php Syntax Highlighting

                 <?php
                                echo "POSTed data: '".$_POST['data']."'";
                 ?>
Parsed in 0.060 seconds,  using GeSHi 1.0.8.4

Corrected it in the first post...

Regards,
plusminus

Doing HTTP Post with Android

Who is online