new widget - Panel

pskink · Master Developer Joined: 24 Nov 2008 Posts: 367

FYI:

fixed flickering when two animations are running in the same time, added overlayed left/right panels

pskink · Master Developer Joined: 24 Nov 2008 Posts: 367

FYI:

some polising / make-up before v 1.0

daRolla: now you can see red button in its full glory :)

Emmanuel7 · Posted: Tue Jan 20, 2009 2:47 am Post subject:

Hum...
you're going too fast for me Smile

Anyway, I made my little contribution, with dealing with the dragging of the handle to move the panel.
I think it is important because I feel it is part of the fun of this widget ( even if you forget about it after ten uses ).

* This version is based on your 0.6 version, so not up to date
* it look like there are some buggy frames in the bottom panel...
* The click is not longer working ( Sad

). But I am unsure of how I can make the difference between a click and a drag !

So still a first step, but I think it is promising !

darolla · Posted: Tue Jan 20, 2009 7:40 am Post subject:

I think a drag is a motion, and a click is a click. both have different event listeners.

although I dont understand the sourcecode completely...

greetings,
darolla

pskink · Master Developer Joined: 24 Nov 2008 Posts: 367

Emmanuel7 · Posted: Tue Jan 20, 2009 2:18 pm Post subject:

Just to elaborate, as my last post was at 3 am for me, and I was getting quite tired :

* The click is clicking on the button, and releasing on the button.
* The drag is cliking on the button, moving, and releasing the button.

But when you click, you can always move by a small amount because..euh...we are not perfect clicker.
Especially, I imagine, on a mobile phone where you are clicking with your finger on pixels that are 1/100 of your finger !

So we have to activate the click behaviour when the release position is 'near' the click position.
I've just tested on the emulator, and that's the home page behaviour. Even if you drag up the panel, then come back two pixels away from the start position, it is considered as a click, and not as a drag

So adding this behavior in my code is no big deal.

Then we can get rid of the click listener, that is of no use now.
with my behaviour, if you release the drag in the upper half of the panel, it will open, otherwise, it will close ( for a BOTTOM panel ).

I still have two questions :
* What is the OnFinishInflate methode about ? I though it was called after the view and its children have been given their size / pos, but it is not the case ! So I don't understand what we must do in this function vs what is done in the constructor
* Is there a callback we can use when the view and its children have been constructed and given their size / pos. In order to mimic this function, I post a message on the OnFinishInflate, and the view is constructed when I receive this message.
* I didn't check the 'fling' mechanism, but I'm not sure it is that important !

more to do :
* I think it is possible to clean the code a little, and remove some dead code / var. We should also put get rid of constantly calling getOrientation, or getVisibility, and use var instead.
* Adding a closePanel and openPanel is about 4 lines, and would be useful ( the application should be able to open/ close the panel when it needs to ).

I'll try to work on it tonigh, it's just two steps from being really great and totally functionnal !!

pskink · Master Developer Joined: 24 Nov 2008 Posts: 367

pskink · Master Developer Joined: 24 Nov 2008 Posts: 367

darolla · Posted: Tue Jan 20, 2009 8:34 pm Post subject:

http://www.anddev.org/viewtopic.php?p=14967

pskink · Master Developer Joined: 24 Nov 2008 Posts: 367

Emmanuel7 · Posted: Wed Jan 21, 2009 2:59 am Post subject:

Waoo !!

it's getting really nice !

I must admit I don't really see what is missing now in order to make it a real v1.0 version.

Two little points :
* First :
There is a bug ! when you drag the handle to have the panel fully expanded ( and pass the limit ), if you release the click button, the panel will instantly close itself. I changed the line 318 :

darolla · Posted: Wed Jan 21, 2009 8:44 am Post subject:

it's really nice Wink

I've found a little bug: open the bottom widget, and try to hit the checkbox. the left widget is opened Sad

so the checkbox is unreachable...

btw: this widget isnt a standard widget. alrite. but cant it be found inside the original sources? it has to be there, because its part of android, isnt it???

altough the graphic cant be found in the sdk...

greetings,
darolla

darolla · Posted: Wed Jan 21, 2009 8:45 am Post subject:

if you click next to the orange grip, the widget openes, too.

so the click hotspot isnt correct?

greetings,
darolla

Emmanuel7 · Posted: Wed Jan 21, 2009 9:58 am Post subject:

I don't think having a unreachable widget when a panel is opened is a bug, just a GUI design issue.
this was just a feature sample, and is not said to be any pratical.

As for the android version, you can find the code here.

I'm unsure why google has released their version, but I'm not sure you can have it on the 4 borders of your app (only bottom and right )