Custom Control - ThresholdEditText

odedo · by **odedo** » Fri May 14, 2010 3:14 pm

Hi pskink,

I've made it possible to change the "extra" properties from the layout xml, but I came across two major flaws:

1. even after adding the xmlns declaration to the layout.xml page, I do not have any intellisens/autocompletion of the new properties (I would expect to have the same "autocomplete" feature that the original EditText attributes has)

2. I found a post that describes the second issue perfectly: http://www.anddev.org/custom_xml_attrib ... t2830.html

I still have not committed those changes to the google code project due to these flaws... If there is a way to fix it, I will commit them.

these are the changes:

attr.xml:

Syntax: [ Download ] [ Hide ]

Using xml Syntax Highlighting

 
<?xml version="1.0" encoding="utf-8"?>
 
<resources>
 
        <declare-styleable name="ThresholdEditText">
 
                <attr name="Threshold" format="integer"/>
 
                <attr name="DisableThresholdOnEmptyInput" format="boolean"/>
 
        </declare-styleable>
 
</resources>
 
Parsed in 0.002 seconds,  using GeSHi 1.0.8.4

ThreshildEditText.java (some more changes were made, that aren't here):

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

 
        /**
 
         * Load properties values from xml layout
 
         */
 
        private void initAttributes(AttributeSet attrs) {
 
                if (attrs != null) {
 
                        // Get the styles attributes
 
                        TypedArray res = getContext().obtainStyledAttributes(attrs,R.styleable.ThresholdEditText);
 
                        // Load values to local members
 
                        this.threshold = res.getInteger(R.styleable.ThresholdEditText_Threshold, 500);
 
                        this.disableThresholdOnEmptyInput = res.getBoolean(R.styleable.ThresholdEditText_DisableThresholdOnEmptyInput, true);
 
                }
 
                else {
 
                        // Default threshold value is 0.5 seconds
 
                        threshold = 500;
 
                        // Default behaviour on emptied text - no threshold
 
                        disableThresholdOnEmptyInput = true;
 
                }
 
        }
 
Parsed in 0.031 seconds,  using GeSHi 1.0.8.4

and the layout.xml:

Syntax: [ Download ] [ Hide ]

Using xml Syntax Highlighting

 
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
 
        xmlns:ma="http://schemas.android.com/apk/res/com.MobileAnarchy.ThresholdEditText"
 
    android:orientation="vertical"
 
    android:layout_width="fill_parent"
 
    android:layout_height="fill_parent"
 
    >
 
        <LinearLayout android:layout_height="wrap_content" android:layout_width="fill_parent" android:layout_margin="10dip">
 
                <TextView android:layout_width="wrap_content" android:layout_height="wrap_content" android:paddingRight="10px" android:text="@string/UserInput"></TextView>
 
                <com.MobileAnarchy.ThresholdEditText.ThresholdEditText 
 
        android:layout_height="wrap_content" 
 
        android:layout_width="fill_parent" 
 
        android:id="@+id/EditTextInput" 
 
        android:lines="1" 
 
        ma:Threshold="500"
 
        ma:DisableThresholdOnEmptyInput="true" />
 
        </LinearLayout>
 
<!-- The rest of of the content was ommited -->
 
Parsed in 0.003 seconds,  using GeSHi 1.0.8.4

Thanks again,

Oded O.

pskink · by **pskink** » Fri May 14, 2010 4:20 pm

i faced the same problem but:

ad 1 - sorry but its ridiculous, so i'll skip this
ad 2 - make your attributes in attrs.xml lowercase (first letter only), just for compatibility, and:

namespace="http://schemas.android.com/apk/res/com.MobileAnarchy.ThresholdEditText"

attrs.getAttributeIntValue(namespace, "treshold", 500)

odedo · by **odedo** » Fri May 14, 2010 5:17 pm

Sorry about the casing issues... as I said, I'm coming from C#, where PascalCasing is the way to go... anyway, I fixed it.

Why to you think that expecting attributes names to have autocompletion is ridiculous?
If I'm adding my namespace, and typing "ma:th..." I would expect the IDE to suggest the value "ma:threshold".

In WPF's XAML, once you add the namespace to the xml file, you have intellisense to both attributes names and their values (if applicable).

I made the changes you suggested, and commited to google code.

Thanks again, its been a great learning expiriecne.

Oded O.

pskink · by **pskink** » Fri May 14, 2010 5:32 pm

odedo wrote:Sorry about the casing issues... as I said, I'm coming from C#, where PascalCasing is the way to go... anyway, I fixed it.

Why to you think that expecting attributes names to have autocompletion is ridiculous?
If I'm adding my namespace, and typing "ma:th..." I would expect the IDE to suggest the value "ma:threshold".

In WPF's XAML, once you add the namespace to the xml file, you have intellisense to both attributes names and their values (if applicable).

I made the changes you suggested, and commited to google code.

Thanks again, its been a great learning expiriecne.

Oded O.

ok, maybe its not ridiculous but not so important

1. if someone is using your view as a jar file how ide is supposed to know your attributes?

2. ok maybe together with your jar someone still has to add your attrs.xml to his/her attrs.xml (i dont remember if its necessary) and maybe goggle will improve in the future their eclipse ADT plugin so it will reckognize your attributes

3. there are many ppl not using eclipse but netbeans for example

4. good work!!!

plusminus · by **plusminus** » Thu May 20, 2010 11:03 am

Hi odedo,

I'd flattr this ( announces/flattr-t14199.html )
But you don't have an account yet

Best Regards,
Nicolas

Custom Control - ThresholdEditText

Re: Custom Control - ThresholdEditText

Who is online