Why isn't my image scaling correctly?

graphitex · by **graphitex** » Mon Jun 13, 2011 6:31 pm

I'm trying to have an image scale to a certain size depending on the horizontal size sent to an update function, but the following code doesnt seem to size the image correctly.

GlassesView.java:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

public class GlassesView extends View {
 
    private Paint paint;
    private BitmapFactory.Options options;
    private Bitmap bitmapOrg;
    private int glassesWidth;
    private int glassesHeight;
 
    public int glassesX;
    public int glassesY;
    public float glassesSizeX;
    public float glassesSizeY;
    private boolean drawGlasses;
 
    public GlassesView(Context context) {
        super(context);
        paint = new Paint();
        paint.setDither(false);
        paint.setAntiAlias(false);
 
        options = new BitmapFactory.Options();
        options.inDither = false;
        options.inScaled = false;
 
        Bitmap bitmapTemp = BitmapFactory.decodeResource(getResources(), R.drawable.micro_glasses, options);
        bitmapOrg = Bitmap.createScaledBitmap(bitmapTemp, 32, 5, false);
 
        glassesWidth = bitmapOrg.getWidth();
        glassesHeight = bitmapOrg.getHeight();
 
        drawGlasses = false;
    }
 
    @Override
    protected void onDraw(Canvas canvas) {
        if(drawGlasses) {
            Matrix matrix = new Matrix();
            matrix.postScale(glassesSizeX, glassesSizeY);
 
            Bitmap resizedBitmap = Bitmap.createBitmap(bitmapOrg, 0, 0, glassesWidth, glassesHeight, matrix, false);
 
            int newWidth = resizedBitmap.getWidth();
            int newHeight = resizedBitmap.getHeight();
            Paint bluey = new Paint();
            bluey.setColor(Color.BLUE);
            canvas.drawRect(new Rect(glassesX, glassesY, glassesX+newWidth, glassesY+newHeight), bluey);
 
            canvas.drawBitmap(resizedBitmap, glassesX, glassesY, paint);
        }
    }
 
    public void updateGlasses(int x, int y, float xsize, float ysize) {
        drawGlasses = true;
        glassesX = x;
        glassesY = y;
        glassesSizeX = (float) xsize / (float) glassesWidth;
        glassesSizeY = glassesSizeX;
    }
 
}
 
Parsed in 0.037 seconds,  using GeSHi 1.0.8.4

MainScreen.java:

Syntax: [ Download ] [ Hide ]

Using java Syntax Highlighting

public class MainScreen extends Activity {
        LinearLayout mLinearLayout;
        GlassesView mGlasses;
        
        int startx;
        int starty;
        int     endx;
 
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        mLinearLayout = new LinearLayout(this);
        
        mLinearLayout.setBackgroundColor(Color.argb(255, 255, 255, 255));
        
        mGlasses = new GlassesView(this);
        
        mGlasses.drawGlasses(80, 80, 32.0f, 32.0f);
        
        mLinearLayout.addView(mGlasses, new LinearLayout.LayoutParams(LayoutParams.FILL_PARENT, LayoutParams.FILL_PARENT));
        
        setContentView(mLinearLayout);
        
        
    }
 
        @Override
        public boolean onTouchEvent(MotionEvent event) {
                int action = event.getAction();
                if(action == MotionEvent.ACTION_DOWN) {
                        startx = (int) event.getX();
                        starty = (int) event.getY()- 40;
                }
                if(action == MotionEvent.ACTION_UP) {
                        endx = (int) event.getX();
                        float scale = endx-startx;
                        mGlasses.drawGlasses(startx, starty, scale, scale);
                        mGlasses.invalidate();
                }
                return super.onTouchEvent(event);
        }
    
    
}
 
Parsed in 0.034 seconds,  using GeSHi 1.0.8.4

The result:

(The blue rectangle being the bounding box of the image's intended size)

At which part am I going wrong?
Thanks in advance

ng.kishore · by **ng.kishore** » Mon Aug 01, 2011 5:35 am

Hi graphitex,

In your GlassView class when creating a bitmap you are scaling the image to 30 x 5, and you are perming changes on this image.

check below code
Bitmap bitmapTemp = BitmapFactory.decodeResource(getResources(), R.drawable.icon, options);
bitmapOrg = Bitmap.createScaledBitmap(bitmapTemp, 32, 5, false);

insted of passing fixed values for bitmapOrg, pass the original width and height of the image, as below
Bitmap bitmapTemp = BitmapFactory.decodeResource(getResources(), R.drawable.icon, options);
bitmapOrg = Bitmap.createScaledBitmap(bitmapTemp, bitmapTemp.getWidth(), bitmapTemp.getHeight(), false);

eee · by **eee** » Mon Aug 01, 2011 1:32 pm

Scaling code scale to 200x50 example:
ImageView im = (ImageView)findViewById(R.id.imageView1);

Bitmap bm = BitmapFactory.decodeResource(getResources(),R.drawable.icon);
Bitmap bs = Bitmap.createScaledBitmap(bm, 200, 50, true);
im.setImageBitmap(bs);

eee · by **eee** » Mon Aug 01, 2011 1:34 pm

I have a problem in cropping an image. The user must point to the section he wishes to crop and the rest of the image will be cut. can anyone help me? its urgent

Why isn't my image scaling correctly?

Why isn't my image scaling correctly?

Re: Why isn't my image scaling correctly?

Re: Why isn't my image scaling correctly?

Re: Why isn't my image scaling correctly?

Who is online